]> www.infradead.org Git - users/dwmw2/qemu.git/commit
block: Expect graph changes in bdrv_parent_drained_begin/end
authorKevin Wolf <kwolf@redhat.com>
Wed, 29 Nov 2017 10:25:10 +0000 (11:25 +0100)
committerKevin Wolf <kwolf@redhat.com>
Wed, 29 Nov 2017 13:22:03 +0000 (14:22 +0100)
commit02d213009d571bcd7171e3ff9234722a11d30d1b
tree9918d9451b520fe39245c7c7341059a503a2c39f
parent0a3e155f3f5ec9b6f12d00894c7701b3cbb66590
block: Expect graph changes in bdrv_parent_drained_begin/end

The .drained_begin/end callbacks can (directly or indirectly via
aio_poll()) cause block nodes to be removed or the current BdrvChild to
point to a different child node.

Use QLIST_FOREACH_SAFE() to make sure we don't access invalid
BlockDriverStates or accidentally continue iterating the parents of the
new child node instead of the node we actually came from.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Tested-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/io.c