]> www.infradead.org Git - users/jedix/linux-maple.git/commit
sched_ext: Fix incorrect time delta calculation in time_delta()
authorChangwoo Min <changwoo@igalia.com>
Sun, 2 Feb 2025 03:37:48 +0000 (12:37 +0900)
committerTejun Heo <tj@kernel.org>
Sun, 2 Feb 2025 17:40:35 +0000 (07:40 -1000)
commit029b6ce733712a41421955194b113f283dcb1026
tree8d2c2c469c98fb917c338fdbb61e13395660c3cf
parent1626e5ef0b00386a4fd083fa7c46c8edbd75f9b4
sched_ext: Fix incorrect time delta calculation in time_delta()

When (s64)(after - before) > 0, the code returns the result of
(s64)(after - before) > 0 while the intended result should be
(s64)(after - before). That happens because the middle operand of
the ternary operator was omitted incorrectly, returning the result of
(s64)(after - before) > 0. Thus, add the middle operand
-- (s64)(after - before) -- to return the correct time calculation.

Fixes: d07be814fc71 ("sched_ext: Add time helpers for BPF schedulers")
Signed-off-by: Changwoo Min <changwoo@igalia.com>
Acked-by: Andrea Righi <arighi@nvidia.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
tools/sched_ext/include/scx/common.bpf.h