]> www.infradead.org Git - users/jedix/linux-maple.git/commit
PCI/bwctrl: Fix pcie_bwctrl_select_speed() return type
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Fri, 21 Mar 2025 16:31:03 +0000 (18:31 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 21 Mar 2025 17:11:38 +0000 (12:11 -0500)
commit026e4bffb0af9632f5a0bbf8d594f2aace44cf07
treeaea6f9215b5c0b7c6daf33c0c6930e20d6ff48df
parentdf6f8c4d72aebaf66aaa8658c723fd360c272e59
PCI/bwctrl: Fix pcie_bwctrl_select_speed() return type

pcie_bwctrl_select_speed() should take __fls() of the speed bit, not return
it as a raw value. Instead of directly returning 2.5GT/s speed bit, simply
assign the fallback speed (2.5GT/s) into supported_speeds variable to share
the normal return path that calls pcie_supported_speeds2target_speed() to
calculate __fls().

This code path is not very likely to execute because
pcie_get_supported_speeds() should provide valid ->supported_speeds but a
spec violating device could fail to synthesize any speed in
pcie_get_supported_speeds(). It could also happen in case the
supported_speeds intersection is empty (also a violation of the current
PCIe specs).

Link: https://lore.kernel.org/r/20250321163103.5145-1-ilpo.jarvinen@linux.intel.com
Fixes: de9a6c8d5dbf ("PCI/bwctrl: Add pcie_set_target_speed() to set PCIe Link Speed")
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/pcie/bwctrl.c