]> www.infradead.org Git - users/jedix/linux-maple.git/commit
clk: socfpga: stratix10: Optimize local variables
authorThorsten Blum <thorsten.blum@linux.dev>
Wed, 19 Feb 2025 10:44:35 +0000 (11:44 +0100)
committerDinh Nguyen <dinguyen@kernel.org>
Thu, 24 Apr 2025 22:38:07 +0000 (17:38 -0500)
commit0248bfb2557932b27d3e1375a3dc6902127b42bc
tree022d67213a2fa094e29127bc1552a7147547fadc
parentab4999906aed5b97985d47e52f7465358cf920e6
clk: socfpga: stratix10: Optimize local variables

Since readl() returns a u32, the local variable reg can also have the
data type u32. Furthermore, mdiv and refdiv are derived from reg and can
also be a u32.

Since do_div() casts the divisor to u32 anyway, changing the data type
of refdiv to u32 removes the following Coccinelle/coccicheck warning
reported by do_div.cocci:

  WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead

Compile-tested only.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
drivers/clk/socfpga/clk-pll-s10.c