]> www.infradead.org Git - users/jedix/linux-maple.git/commit
rxrpc: Improve setsockopt() handling of malformed user input
authorMichal Luczaj <mhal@rbox.co>
Tue, 19 Nov 2024 13:31:42 +0000 (14:31 +0100)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 28 Nov 2024 07:57:42 +0000 (08:57 +0100)
commit02020056647017e70509bb58c3096448117099e1
tree23f7ebe3126a6c9988c1f53cfd9cf5aa74ce3f79
parent1465036b10be4b8b00eb31c879e86de633ad74c1
rxrpc: Improve setsockopt() handling of malformed user input

copy_from_sockptr() does not return negative value on error; instead, it
reports the number of bytes that failed to copy. Since it's deprecated,
switch to copy_safe_from_sockptr().

Note: Keeping the `optlen != sizeof(unsigned int)` check as
copy_safe_from_sockptr() by itself would also accept
optlen > sizeof(unsigned int). Which would allow a more lenient handling
of inputs.

Fixes: 17926a79320a ("[AF_RXRPC]: Provide secure RxRPC sockets for use by userspace and kernel both")
Signed-off-by: Michal Luczaj <mhal@rbox.co>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/rxrpc/af_rxrpc.c