]> www.infradead.org Git - users/jedix/linux-maple.git/commit
KVM: arm64: vgic-debug: Exit the iterator properly w/o LPI
authorZenghui Yu <yuzenghui@huawei.com>
Wed, 7 Aug 2024 05:20:24 +0000 (13:20 +0800)
committerOliver Upton <oliver.upton@linux.dev>
Wed, 7 Aug 2024 19:10:22 +0000 (19:10 +0000)
commit01ab08cafeced7ae1d6c01a08218742c8182f8da
tree7100dd0811d0a746da226bb6ef3fe50cf4fd2c54
parent10f2ad032defe906240d0c3b62dcbceace96b230
KVM: arm64: vgic-debug: Exit the iterator properly w/o LPI

In case the guest doesn't have any LPI, we previously relied on the
iterator setting

'intid = nr_spis + VGIC_NR_PRIVATE_IRQS' && 'lpi_idx = 1'

to exit the iterator. But it was broken with commit 85d3ccc8b75b ("KVM:
arm64: vgic-debug: Use an xarray mark for debug iterator") -- the intid
remains at 'nr_spis + VGIC_NR_PRIVATE_IRQS - 1', and we end up endlessly
printing the last SPI's state.

Consider that it's meaningless to search the LPI xarray and populate
lpi_idx when there is no LPI, let's just skip the process for that case.

The result is that

* If there's no LPI, we focus on the intid and exit the iterator when it
  runs out of the valid SPI range.
* Otherwise we keep the current logic and let the xarray drive the
  iterator.

Fixes: 85d3ccc8b75b ("KVM: arm64: vgic-debug: Use an xarray mark for debug iterator")
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
Acked-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20240807052024.2084-1-yuzenghui@huawei.com
Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
arch/arm64/kvm/vgic/vgic-debug.c