]> www.infradead.org Git - users/jedix/linux-maple.git/commit
accel/habanalabs: move heartbeat work initialization to early init
authorTomer Tayar <ttayar@habana.ai>
Mon, 13 May 2024 11:40:35 +0000 (14:40 +0300)
committerOfir Bitton <obitton@habana.ai>
Sun, 23 Jun 2024 06:53:33 +0000 (09:53 +0300)
commit0199e6392e067299ece25863abd7453e4823f13b
treebb3a1b63512865f5a0db2dbc39b7e4949d9a80ea
parent5cb97d74c3c7ad93750fc3f11875159500380d1c
accel/habanalabs: move heartbeat work initialization to early init

The device heartbeat work is currently initialized at
device_heartbeat_schedule() which is called at the end of
hl_device_init().
However hl_device_init() can fail at a previous step, and in such a
case, a subsequent call to hl_device_fini() will lead to calling
cleanup_resources() and accessing this work uninitialized.

As there is no real need to re-initialize this work every time it is
rescheduled, move this initialization to device_early_init() to be done
once and early enough.

Signed-off-by: Tomer Tayar <ttayar@habana.ai>
Reviewed-by: Ofir Bitton <obitton@habana.ai>
Signed-off-by: Ofir Bitton <obitton@habana.ai>
drivers/accel/habanalabs/common/device.c