]> www.infradead.org Git - users/willy/pagecache.git/commit
ALSA: seq: oss: Fix races at processing SysEx messages
authorTakashi Iwai <tiwai@suse.de>
Mon, 30 Dec 2024 11:05:35 +0000 (12:05 +0100)
committerTakashi Iwai <tiwai@suse.de>
Mon, 30 Dec 2024 11:06:28 +0000 (12:06 +0100)
commit0179488ca992d79908b8e26b9213f1554fc5bacc
treec0907634866b42a8b4e1fa9d8cdda480da51a030
parent7439b395211874e20c24b2fe0e4903864357a3f5
ALSA: seq: oss: Fix races at processing SysEx messages

OSS sequencer handles the SysEx messages split in 6 bytes packets, and
ALSA sequencer OSS layer tries to combine those.  It stores the data
in the internal buffer and this access is racy as of now, which may
lead to the out-of-bounds access.

As a temporary band-aid fix, introduce a mutex for serializing the
process of the SysEx message packets.

Reported-by: Kun Hu <huk23@m.fudan.edu.cn>
Closes: https://lore.kernel.org/2B7E93E4-B13A-4AE4-8E87-306A8EE9BBB7@m.fudan.edu.cn
Cc: <stable@vger.kernel.org>
Link: https://patch.msgid.link/20241230110543.32454-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/seq/oss/seq_oss_synth.c