]> www.infradead.org Git - users/jedix/linux-maple.git/commit
cxgb4: fix memory leak in cxgb4_init_ethtool_filters() error path
authorAbdun Nihaal <abdun.nihaal@gmail.com>
Mon, 14 Apr 2025 17:06:46 +0000 (22:36 +0530)
committerJakub Kicinski <kuba@kernel.org>
Thu, 17 Apr 2025 00:52:18 +0000 (17:52 -0700)
commit00ffb3724ce743578163f5ade2884374554ca021
tree78836271d97a4bfe8288dea15a3dcd2cae2fd764
parentadf6b730fc8dc61373a6ebe527494f4f1ad6eec7
cxgb4: fix memory leak in cxgb4_init_ethtool_filters() error path

In the for loop used to allocate the loc_array and bmap for each port, a
memory leak is possible when the allocation for loc_array succeeds,
but the allocation for bmap fails. This is because when the control flow
goes to the label free_eth_finfo, only the allocations starting from
(i-1)th iteration are freed.

Fix that by freeing the loc_array in the bmap allocation error path.

Fixes: d915c299f1da ("cxgb4: add skeleton for ethtool n-tuple filters")
Signed-off-by: Abdun Nihaal <abdun.nihaal@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20250414170649.89156-1-abdun.nihaal@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c