]> www.infradead.org Git - nvme.git/commit
nvme-ioctl: fix leaked requests on mapping error
authorKeith Busch <kbusch@kernel.org>
Tue, 25 Feb 2025 01:13:30 +0000 (17:13 -0800)
committerKeith Busch <kbusch@kernel.org>
Tue, 25 Feb 2025 17:09:18 +0000 (09:09 -0800)
commit00817f0f1c45b007965f5676b9a2013bb39c7228
tree2b77d45e88ec9b47a2846b53adb13ab452b92bf7
parent56cf7ef0d490b28fad8f8629fc135c5ab7c9f54e
nvme-ioctl: fix leaked requests on mapping error

All the callers assume nvme_map_user_request() frees the request on a
failure. This wasn't happening on invalid metadata or io_uring command
flags, so we've been leaking those requests.

Fixes: 23fd22e55b767b ("nvme: wire up fixed buffer support for nvme passthrough")
Fixes: 7c2fd76048e95d ("nvme: fix metadata handling in nvme-passthrough")
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/ioctl.c