]> www.infradead.org Git - users/jedix/linux-maple.git/commit
bpftool: Fix readlink usage in get_fd_type
authorViktor Malik <vmalik@redhat.com>
Wed, 29 Jan 2025 07:18:57 +0000 (08:18 +0100)
committerAlexei Starovoitov <ast@kernel.org>
Mon, 3 Feb 2025 11:33:51 +0000 (03:33 -0800)
commit0053f7d39d491b6138d7c526876d13885cbb65f1
tree927ece76c07fe08a6f706520f96e30146a37c312
parentcb3ade567816a03d1ac1c33bf86073574efcfcaf
bpftool: Fix readlink usage in get_fd_type

The `readlink(path, buf, sizeof(buf))` call reads at most sizeof(buf)
bytes and *does not* append null-terminator to buf. With respect to
that, fix two pieces in get_fd_type:

1. Change the truncation check to contain sizeof(buf) rather than
   sizeof(path).
2. Append null-terminator to buf.

Reported by Coverity.

Signed-off-by: Viktor Malik <vmalik@redhat.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Reviewed-by: Quentin Monnet <qmo@kernel.org>
Link: https://lore.kernel.org/bpf/20250129071857.75182-1-vmalik@redhat.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/bpf/bpftool/common.c