]> www.infradead.org Git - users/jedix/linux-maple.git/commit
be2net: don't flip hw_features when VXLANs are added/deleted
authorDavide Caratti <dcaratti@redhat.com>
Wed, 3 Oct 2018 13:20:58 +0000 (15:20 +0200)
committerBrian Maly <brian.maly@oracle.com>
Sat, 11 May 2019 03:44:38 +0000 (23:44 -0400)
commit003c1f8f581ecdf0908d3151300b8db780e709eb
tree59ff0912274e9a1cb0d2b2fcbfc36c8efa615f64
parentfa4f988a35e13f714a00b4bf8c758a0de155e265
be2net: don't flip hw_features when VXLANs are added/deleted

Orabug: 29475071

the be2net implementation of .ndo_tunnel_{add,del}() changes the value of
NETIF_F_GSO_UDP_TUNNEL bit in 'features' and 'hw_features', but it forgets
to call netdev_features_change(). Moreover, ethtool setting for that bit
can potentially be reverted after a tunnel is added or removed.

GSO already does software segmentation when 'hw_enc_features' is 0, even
if VXLAN offload is turned on. In addition, commit 096de2f83ebc ("benet:
stricter vxlan offloading check in be_features_check") avoids hardware
segmentation of non-VXLAN tunneled packets, or VXLAN packets having wrong
destination port. So, it's safe to avoid flipping the above feature on
addition/deletion of VXLAN tunnels.

Fixes: 630f4b70567f ("be2net: Export tunnel offloads only when a VxLAN tunnel is created")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Brian Maly <brian.maly@oracle.com>
Reviewed-by: John Donnelly <John.p.donnelly@oracle.com>
Signed-off-by: Brian Maly <brian.maly@oracle.com>
drivers/net/ethernet/emulex/benet/be_main.c