]> www.infradead.org Git - nvme.git/commit
selftests/bpf: Fix tests after fields reorder in struct file
authorSong Liu <song@kernel.org>
Thu, 27 Mar 2025 18:55:28 +0000 (11:55 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Thu, 3 Apr 2025 04:55:43 +0000 (21:55 -0700)
commit00387808d36e23c7d56e9e04a31de0be1443b0e9
tree7e66ce063840256aa714fceb3f2fc5087aac26aa
parent5d0b204654de25615cf712be86c3192eca68ed80
selftests/bpf: Fix tests after fields reorder in struct file

The change in struct file [1] moved f_ref to the 3rd cache line.
It made *(u64 *)file dereference invalid from the verifier point of view,
because btf_struct_walk() walks into f_lock field, which is 4-byte long.

Fix the selftests to deference the file pointer as a 4-byte access.

[1] commit e249056c91a2 ("fs: place f_ref to 3rd cache line in struct file to resolve false sharing")
Reported-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20250327185528.1740787-1-song@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/testing/selftests/bpf/progs/test_module_attach.c
tools/testing/selftests/bpf/progs/test_subprogs_extable.c